Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting moves from UCI are not accepted #4

Open
brane-games opened this issue Nov 17, 2022 · 1 comment
Open

Promoting moves from UCI are not accepted #4

brane-games opened this issue Nov 17, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@brane-games
Copy link
Contributor

When a match between engines using UCI is played, a promoting move has the format of: h7h8q. This move is not accepted by the library and I believe it should be. Of course it is trivial to convert the h7h8q to h8=Q but I believe this should be supported out of the box.

To Reproduce

var board = ChessBoard.LoadFromFen("8/4R2P/3K4/8/p7/P2b4/1P6/3k4 w - - 3 68");
board.Move("h7h8q");

Expected behaviour
The move is accepted.

I'd be willing to implement this myself if you agree that this is a bug. Thanks a lot for the great library!

@brane-games brane-games added the bug Something isn't working label Nov 17, 2022
@Geras1mleo
Copy link
Owner

This library supports SAN and default methods use mainly SAN.
If you are willing to implement your format (I am totally supporting it) you should add new builder class (next to SanBuilder) and new class in Convertions/ folder with public parsing methods.
Dont forget about testing ;)
I appreciate your interest in my library!

@Geras1mleo Geras1mleo added enhancement New feature or request and removed bug Something isn't working labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants