Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial recipe_compat framework #109

Merged
merged 3 commits into from
Apr 26, 2018
Merged

initial recipe_compat framework #109

merged 3 commits into from
Apr 26, 2018

Conversation

bell07
Copy link
Collaborator

@bell07 bell07 commented Mar 9, 2018

Be more flexible for #73
This PR does nothing new but allow change recipes depending on installed mods.
It is an preparation for recipes without some mesecons mods but with homedecor for examle.

The idea is to add fallback mapping from default mod
silicon => group:sand for example. But this idea is still incomplete.

At the first I look which Items I need to replace in recipes to be compatible with my whynot subgame

@Gerold55
Copy link
Owner

Gerold55 commented Mar 9, 2018

Sounds good to me.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 10, 2018

Added recipe compatibility for homedecor items instead of mesecons gates, fpga and luacontroller to be compatible to the whynot game. If both mods (homedecor + mesecons_*) installed the mesecons items are used. Of course additional ideas and mappings welcome. In order we can define the priorities. Ideally we need for all items fallback items from default mod.

By the way, the "floppy" needs more materials then the computer case, was slightly strange for me...

@Grizzly-Adam
Copy link
Contributor

In real life floppies are a film disk with bits of a magnetic metal on them, covered in a plastic case. And, of course, there is a piece of aluminum the slides open and closed on 3 1/2" floppies. There are no electronics inside them.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 12, 2018

My first computer used 8" floppies, so I know about the inside ;-)

The motor was the best mapping for "controller" for me. I think the "controller" is misplaced in mesecons recipe variant too for floppy.

@Grizzly-Adam
Copy link
Contributor

I could make a seperate floppy drive component.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 12, 2018

The separate floppy drive component needs an recipe too ;-)

At the end all own items needs to be crafteable by "default" items or by other often installed mods like homedecor, xdecor, technic, mesecons.

@Grizzly-Adam
Copy link
Contributor

Grizzly-Adam commented Mar 12, 2018 via email

@bell07
Copy link
Collaborator Author

bell07 commented Mar 12, 2018

Can this pull be merged or further ideas what should be added / changed / adjusted?

@bell07 bell07 closed this Mar 12, 2018
@bell07 bell07 reopened this Mar 12, 2018
@Grizzly-Adam
Copy link
Contributor

Im at work, havent been able to look at the pull.

@Grizzly-Adam
Copy link
Contributor

Grizzly-Adam commented Mar 13, 2018

Floppy texture is in my git as promised.

Everything looks good to me in here. But I don't care about recipes as much as you guys.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

Did not found the file in any branch :-(

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

I did not understand the idea for floppy drive. The issue was an component to craft floppy that is not motor or controller because the floppy does not have any electronic inside :-/

@Grizzly-Adam
Copy link
Contributor

Grizzly-Adam commented Mar 13, 2018 via email

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

We need a recipe for electronic-less floppy item that is used to store data. Your critique was the homedecor motor item is misplaced, for me the mesecons controller is misplaced too. So we need a more realistic idea how to craft the floppy

@Grizzly-Adam
Copy link
Contributor

Floppies are 99 percent plastic and a little bit of magnetic metal. How do we make plastic? In the media pack I used a recipe of 8 obsidian shards and a steel ingot to make the 5.25" floppy disk.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

I like the homedecor's plastic sheeting for "my variant". Do not know which item could be used from mesecons. Anything with the mesecons_materials:glue?

magnetic metal could be default:iron_lump.

@Grizzly-Adam
Copy link
Contributor

That's good, I like that. The glue, not so much. Don't they have like a plastic coating for wires? Insulation?

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

Insulation?
Cooked glue is mesecons_materials:fiber that is used for insulation

@Grizzly-Adam
Copy link
Contributor

Fiber-- that's it.

@Grizzly-Adam
Copy link
Contributor

Maybe use a combo of fiber and glue with iron lump for floppies. Refine the metal as the disks get bigger. For instance, 5.25" used iron lump. 3.5" could use steel ignot. Larger disks like zip drive or mini disk if we decide to make these could use steel cube.

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

A cube is 1 meter x 1 meter x 1 meter if placed. Ok for computer case, but really to much for mini disk ;-)

@Grizzly-Adam
Copy link
Contributor

I am imagining that it is compressed during the crafting process. You know how they are always fitting more components into smaller cases :)

@bell07
Copy link
Collaborator Author

bell07 commented Mar 13, 2018

@Grizzly-Adam
Copy link
Contributor

lol

@bell07
Copy link
Collaborator Author

bell07 commented Mar 14, 2018

rebased to current upstream

@bell07 bell07 mentioned this pull request Mar 20, 2018
@bell07 bell07 merged commit c2981e9 into Gerold55:master Apr 26, 2018
@bell07 bell07 deleted the recipe_compat branch April 26, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants