Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper HTML lists #3266

Closed
mgifford opened this issue Nov 13, 2020 · 1 comment
Closed

Use proper HTML lists #3266

mgifford opened this issue Nov 13, 2020 · 1 comment

Comments

@mgifford
Copy link

Describe the bug

This is broken HTML:
<ol><div class="dc-search-list-item">

http://demo.getdkan.org/search/

Screenshot of search page

If you're going to use a list then it should be a list element and not a div. Div's should only be for things with no semantic meaning.

Discovered using MS's https://accessibilityinsights.io/ (which uses Axe):
AutomatedChecks_20201113_SearchDKANDemo.html.zip

Steps To Reproduce

Run Accessibility Insights on search page.

Expected behavior

We should be able to replicate Drupal's search results. We've looked that over for accessibility.

@dgading
Copy link
Member

dgading commented Feb 12, 2021

Fixed in data-catalog-components

@dgading dgading closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants