Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blank screen on offline support if user id is lazily set #2003

Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix: blank screen on offline support if user id is lazily set #2003

merged 2 commits into from
Mar 13, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Mar 13, 2023 •
edited
Loading

🎯 Goal

#2001 caused a bug that a blank screen would appear if user id is not set on offline support. This PR fixes it.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit 2cc2d4a into develop Mar 13, 2023
@santhoshvai santhoshvai deleted the db-initialise-fix branch March 13, 2023 15:56
@santhoshvai
Copy link
Member Author

Merged this without review , as it will be tested by Feeld with a beta

@github-actions github-actions bot mentioned this pull request Mar 16, 2023
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santhoshvai @stream-ci-bot