-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initial scroll to first unread message was broken when there more than 55 unread messages #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
vanGalilea
reviewed
Mar 21, 2023
vanGalilea
approved these changes
Mar 21, 2023
Merged
🎉 This PR is included in version 5.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
While @khushal87 investigated #2004, he found that when there were large number of unread messages, the scroll to first unread was broken
🛠 Implementation details
The main fix is f35b448. This fixed a lot of issues
Demo
Simulator.Screen.Recording.-.iPhone.14.-.2023-03-20.at.19.03.41.mp4
🧪 Testing
Case 1
for i in {1..7}; do stream-cli chat send-message --user "25100e34-4450-3dcb-82eb-fbc34d2b421b" --channel-id "c1ece5ff-a5b1-4e4c-305c-4313fbc2e876" --channel-type "messaging" --text
date +"%T"; done
Case 2
for i in {1..80}; do stream-cli chat send-message --user "25100e34-4450-3dcb-82eb-fbc34d2b421b" --channel-id "c1ece5ff-a5b1-4e4c-305c-4313fbc2e876" --channel-type "messaging" --text
date +"%T"; done
And there should be no unnecessary blank list when this happens. This was a rerender issue before!
☑️ Checklist
develop
branch