[CIS-1213] Fix custom Components being not retrievable

[evsaev]

🔗 Issue

CIS-1213

🎯 Goal

Fix responder chain being cutoff when ComposerVC/ChatMessageListVC controllers lifecycle is running which leads to the subviews of wrong types being instantiated.

Fix the lifecycle of ChatMessageContentView being triggered before a message cell is part of view hierarchy.

🛠 Implementation

The base view controller was updated to fallback to parent view controller if the responder chain backed by view hierarchy has not yet been established.

🧪 Testing

The PR contains unit tests added that check the responder chain is not cutoff at the moment when child controllers instantiate their subviews. The unit test that at the moment makes CI red is fixed by the changes done in ChatMessageCell/ChatMessageContentView.

🎨 Changes

☑️ Checklist

• I have signed the Stream CLA (required)
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Affected documentation updated (docusaurus, tutorial, CMS (task created)

[codecov-commenter]

Codecov Report

Merging #1519 (118e43f) into main (48313cb) will decrease coverage by 0.03%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   74.36%   74.32%   -0.04%     
==========================================
  Files         231      231              
  Lines       10781    10796      +15     
==========================================
+ Hits         8017     8024       +7     
- Misses       2764     2772       +8     

Flag	Coverage Δ
llc-tests	74.32% <29.41%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ListController/ChannelListController+Combine.swift	68.42% <0.00%> (-31.58%)	⬇️
...ListController/ChannelListController+SwiftUI.swift	68.42% <0.00%> (-31.58%)	⬇️
.../ChannelListController/ChannelListController.swift	33.50% <ø> (+0.34%)	⬆️
...ources/StreamChat/Workers/ChannelListUpdater.swift	93.33% <100.00%> (+1.33%)	⬆️
...StreamChat/Database/DTOs/ChannelListQueryDTO.swift	90.00% <0.00%> (+10.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10fe03...118e43f. Read the comment docs.

[nuno-vieira]

It seems that some components still have problems 🤔

[evsaev]

It seems that some components still have problems 🤔

ChatMessageContentView was updated to trigger the layout when the it's added as a subview. Two tests were red because the content view was not added to the view hierarchy. It's fixed now so let's see if CI is green🤞

[nuno-vieira]

LGTM 🎉

[b-onc]

CHANGELOG?

[nuno-vieira]

LGTM

[nuno-vieira]

@evsaev I still find it weird, why this happens. Customers are not complaining they can't customize these components. Also, we have these components customized in our sample apps. Why is this happening only on the tests?

[evsaev]

@evsaev I still find it weird, why this happens. Customers are not complaining they can't customize these components. Also, we have these components customized in our sample apps. Why is this happening only on the tests?

Customers do not face with this issues because they inject components via Components.default and it works well. If they tried to use custom components in specific view sub-tree they would see it is broken.

In most of snapshot tests UI components are sand-boxed so the ChannelListVC was actually the only place where the responder chain is long enough.

[nuno-vieira]

@evsaev I still find it weird, why this happens. Customers are not complaining they can't customize these components. Also, we have these components customized in our sample apps. Why is this happening only on the tests?

Customers do not face with this issues because they inject components via Components.default and it works well. If they tried to use custom components in specific view sub-tree they would see it is broken.

In most of snapshot tests UI components are sand-boxed so the ChannelListVC was actually the only place where the responder chain is long enough.

Ahhhh now it all makes sense 🙌

[nuno-vieira]

LGTM 🎉