Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-2209] Fix message text not dynamically scalable with content size category changes #2328

Merged
merged 4 commits into from Oct 10, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 7, 2022

🔗 Issue Links

CIS-2209
#2325

🎯 Goal

Fix message text not dynamically scalable with content size category changes.

🛠 Implementation

The forcedScaledFont() function description provides all the details on why this is needed. But to sum up, on the message cell, we need to create always a new instance of a scaled UIFont, otherwise, the changes won't be reflected.

🎨 Showcase

🧪 Manual Testing Notes

  • Open a Channel
  • Open Xcode > Developer Tools > Accessibility Inspector
  • Select the Simulator
  • Select the 3rd top right corner button
  • Change the dynamic type
  • Should change the message content text

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Oct 7, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner October 7, 2022 21:33
@nuno-vieira nuno-vieira force-pushed the fix/CIS-2209-message-text-not-dynamically-scaled branch from 93610c4 to 18939f3 Compare October 7, 2022 21:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nuno-vieira nuno-vieira merged commit 7bad958 into develop Oct 10, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-2209-message-text-not-dynamically-scaled branch October 10, 2022 14:35
@nuno-vieira nuno-vieira mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants