New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong message text font when text accessibility is larger + Snapshot Testing Framework Update #2575
Fix wrong message text font when text accessibility is larger + Snapshot Testing Framework Update #2575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we end up changing that justifies the change on the snapshots?
Sources/StreamChatUI/ChatMessageList/ChatMessage/ChatMessageContentView.swift
Show resolved
Hide resolved
Sources/StreamChatUI/ChatMessageList/ChatMessage/ChatMessageContentView.swift
Outdated
Show resolved
Hide resolved
4994edd
to
6cd190a
Compare
…ntentView.swift Co-authored-by: Pol Quintana <pol.quintana1@gmail.com>
Yes, the CheckmarkView now has a different size. It is a little a bit bigger now to improve the UI when text accessibility is bigger |
Kudos, SonarCloud Quality Gate passed! |
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/371
🎯 Goal
Fixes the message text font when the text accessibility setting is set to larger.
This issue was introduced by this PR, which we tried to fix the dynamic font size for the message text, but this actually causes the text font to be with an incorrect size after closing/opening the app. So we need to revert that change.
For now, we don't know the root cause of why the font is not changed dynamically, and it only changes after closing the app. But there is a workaround to overcome this, and it is to override the
MessageContentView.defaultMessageFont
to always return a new UIFont instance (Ex:UIFont.preferredFont(forTextStyle: .body)
). More context here.Bonus: Fixes the message timestamp label and checkmark delivery status issues when the font size is larger.
📝 Summary
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist