Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file attachments not rendering file size #2941

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Dec 19, 2023

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/679

🎯 Goal

Fix file attachments not rendering file size when loading the attachments from the server.

🛠 Implementation

This issue was happening because we were not rendering the file size the local uploadingState was nil.

🧪 Manual Testing Notes

  1. Upload a file
  2. Should show the size of the file.
  3. Logout
  4. Login
  5. Load the same file from the server
  6. It should still show the size of the file.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Dec 19, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner December 19, 2023 11:58
@nuno-vieira nuno-vieira force-pushed the fix/file-attachments-not-rendering-file-size branch from 76b6995 to 62af3bd Compare December 19, 2023 12:02
@nuno-vieira nuno-vieira enabled auto-merge (squash) December 19, 2023 12:55
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

47 New issues
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nuno-vieira nuno-vieira merged commit 0bc0a1f into develop Dec 19, 2023
16 checks passed
@nuno-vieira nuno-vieira deleted the fix/file-attachments-not-rendering-file-size branch December 19, 2023 13:20
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants