New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to customize ComposerVC.updateContent()
#3112
Merged
nuno-vieira
merged 9 commits into
develop
from
add/make-it-easier-to-customize-composer-update-content
Mar 25, 2024
Merged
Make it easier to customize ComposerVC.updateContent()
#3112
nuno-vieira
merged 9 commits into
develop
from
add/make-it-easier-to-customize-composer-update-content
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
✅ Feature
An issue or PR related to a feature
labels
Mar 22, 2024
StreamChat XCMetrics
|
laevandus
reviewed
Mar 22, 2024
…' of github.com:GetStream/stream-chat-swift into add/make-it-easier-to-customize-composer-update-content
laevandus
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
martinmitrevski
approved these changes
Mar 22, 2024
StreamChat XCMetrics
|
Quality Gate passedIssues Measures |
nuno-vieira
deleted the
add/make-it-easier-to-customize-composer-update-content
branch
March 25, 2024 14:50
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✅ Feature
An issue or PR related to a feature
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves #3074
🎯 Goal
Make it easier to customize
ComposerVC.updateContent()
by breaking it down into multiple functions.📝 Summary
Because of the composer's text view, in some scenarios, hiding and showing views twice can cause the input text view to jitter. These separation of the updateContent function will make sure that a customer can set the visibility of buttons only once. Or at least make it easier to do it.
🧪 Manual Testing Notes
N/A, UI and E2E Tests should pass to make sure there are no regressions.
☑️ Contributor Checklist