Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): failing TS check #537

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix(utils): failing TS check #537

merged 4 commits into from
Feb 14, 2023

Conversation

nima-lighthouse
Copy link
Contributor

@nima-lighthouse nima-lighthouse commented Feb 1, 2023 •
edited by arnautov-anton
Loading

Fixes: #536

@arnautov-anton arnautov-anton changed the title Fix failing Typescript check fix(utils): failing TS check Feb 14, 2023
@arnautov-anton arnautov-anton enabled auto-merge (squash) February 14, 2023 22:43
@arnautov-anton
Copy link
Collaborator

Hey, @nima-lighthouse! Thank you for your contribution - some tests are failing due to your PR coming from a fork and GH somehow fails to inject enviroment variables for it to (at least) run. But the change makes sense, the TS test passes so I'm going to approve and merge. Also - sorry for the rebase!

@arnautov-anton arnautov-anton enabled auto-merge (squash) February 14, 2023 23:13
@arnautov-anton arnautov-anton merged commit bb21585 into GetStream:main Feb 14, 2023
@nima-lighthouse
Copy link
Contributor Author

Hey, @nima-lighthouse! Thank you for your contribution - some tests are failing due to your PR coming from a fork and GH somehow fails to inject enviroment variables for it to (at least) run. But the change makes sense, the TS test passes so I'm going to approve and merge. Also - sorry for the rebase!

Hey @arnautov-anton! Thanks for taking care of this. I don't see my changes in the new version of the npm package though... Is it going to be published soon?
Thanks!

@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Merged
@arnautov-anton
Copy link
Collaborator

Now available in the version 8.1.2. 👍 @nima-lighthouse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnautov-anton arnautov-anton arnautov-anton approved these changes

@MartinCupela MartinCupela Awaiting requested review from MartinCupela MartinCupela is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript check ERROR in node_modules/getstream/src/utils.ts:103:15
2 participants
@nima-lighthouse @arnautov-anton