Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue support for Node versions < v8.0.0? #36

Closed
dwightgunning opened this issue Sep 5, 2017 · 5 comments
Closed

Continue support for Node versions < v8.0.0? #36

dwightgunning opened this issue Sep 5, 2017 · 5 comments
Assignees
Labels

Comments

@dwightgunning
Copy link
Contributor

The recent Prettier styling (43a3acd) seems to have introduced trailing commas in function calls throughout the codebase. This ES2017 syntax causes errors with Node versions <v8.0.0 as raised in #35.

Should we strip these trailing commas in order to return to supporting Node v7 (and earlier)? Or rather update the README and blog posts to highlight the minimum version of Node?

@sadzebra
Copy link

sadzebra commented Sep 5, 2017

I guess it would depend on LTS support. I thought this might help with a decision.

https://github.com/nodejs/LTS#lts-schedule1

@dwightgunning
Copy link
Contributor Author

@sadzebra The release maintenance and LTS schedule is definitely something to consider.

My instinct is that since this is 'showcase' application, the codebase ought to continually move forward and adopt new language features as soon as they're available. Contrast that to our API Client libraries and Framework Integration libraries which are dependencies of other projects and should therefore retain support for all Node versions that being maintained.

In this case we should definitely be more clear about what version of Node is required. That probably includes a mention in the accompanying blog entry and as well as setting the 'engines' property in package.json.

I'd interested to hear your thoughts on this; does that seem a logical approach?

We'll also get input from @nparsons08 who led this recent round of updates. There may be something I'm overlooking.

@sadzebra
Copy link

sadzebra commented Sep 5, 2017

Yeah, i'd have to agree, seems like the logical approach. The LTS is in maintenance at the moment so in theory anyone using that should be looking into migrating anyway. Also version 7.x doesn't have support now so i would assume that the majority of users will be on 8.x or moving to 8.x, which also has LTS until 2019.

I've added a comment on the blog advising users to upgrade the version of node already, but writing that into the blog post itself would be worth it.

Is the blog a collaborative project as I've found a couple of points that could do with updating. (I've put them in the comments section)

@dwightgunning
Copy link
Contributor Author

Is the blog a collaborative project as I've found a couple of points that could do with updating. (I've put them in the comments section)

Comments on the blog pointing out areas for improvement are most appreciated. We're a fairly small team juggling quite a few projects, libraries, languages, etc. so sometimes it takes longer than we'd like to respond. But we do really love the fixes and feedback!

@astrotars
Copy link
Contributor

Hi all, just a quick update from my end. Provided that Cabin is a tutorial, we've decided to keep it up to date with the latest version of Node.js (currently 8.4). If you're running an outdated version of Node.js, we encourage you to upgrade to avoid breaking changes that were pushed during the last update – apologies for not making that clear. Closing this out for now, however, feel free to open up new issues should they arise. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants