-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate a Sass Compiler #50
Comments
Uikit 2 also has sass, I made a child theme, with sass version |
In talking with @ThierryA, we are considering moving to a browser-based JS compiler architecture and away from PHP. If we go that route, then we can begin testing the coverage and robustness of a tool like Sass.js. Sass.js has a playground page for us to begin testing different Sass files to determine if this solution will work for us...or not. If yes, then we can begin architecting connection points between it, Beans, and the server filesystem for caching the compiled file. |
Do it via JS task runner eg. webpack, gulp, mix seems like the modern approach. So make it a breaking change in V2? Could that be a plugin? How do we think developers use the setup? In my workflow Sass -> CSS is something for my local development environment and for the deployment. In the practice I follow, the depolyment system is what serves the final CSS files. I am still a fan of checking out tools like Gulp WP Toolkit or similar and see if that could be used or extended to be a good partner. |
Oh - "browser-based" means the server sends Sass and the browser compiles it when the site is loaded? |
@ibes So the difference with that approach (i.e. the local compiler through a tooling) and Beans is:
Think about that. You can set the global branding in your child theme. Then each plugin can use those globals for specific components that are within the plugin. It allows developers to build smaller packages without the bloat. Beans' Compiler API works at the system level. Gulp, Webpack, etc. work at the local level, i.e. within a single plugin or theme. That said, you can build system-wide local compiling via gulp, webpack, etc; however, for us, we can't assume that the developer is compiling everything. Right? So we provide a Compiler within Beans. Does that make sense? |
Now as for browser vs. server side compiling, I'm not convinced yet about pushing it out to the browser. Thierry's has voiced interest in browser-side. So we're discussing the pros and cons, challenges, complexity, and future of either architecture. We welcome all discussions and feedback. |
I'd like to hear more about the benefits and disadvantages of browser-side compiling vs. server-side compiling. E.g. performance, security, reliability, error handling, supporting documentation,... |
@hellofromtonya And I understand why a framework intern solution will be needed for that. About wording: Disadvantages of browser based:
A big question will be: On Browser side compilation: Sass and SCSS |
I'm a Sass gal. Bringing Sass compilation to Beans is a leap forward for flexibility and developer personal preference. UIKit 3 also brings us Sass.
Currently, Beans has integrated LESS compilation. Let's give developers a choice of LESS or Sass by integrating a Sass compiler.
The text was updated successfully, but these errors were encountered: