Fixed TextDisplay's offsets.

[stromsoftware]

Fixed TextDisplay's offsets by adding the Translation (https://wiki.vg/Entity_metadata#Entity_Metadata_Format), mainly for passenger entities.

[stromsoftware]

Why is this still not approved?

[onebeastchris]

Here you go - after these, this should be good to merge. If you have questions about how to implement specifics, feel free to reach out via discord.

[onebeastchris]

Looks better now, but if you're alright with that, I'd push a few minor changes to this PR myself - I'm pretty sure that we could cancel the entity mount offset from getting applied in a way that doesn't involve adding an extra check to that static method.

[stromsoftware]

Looks better now, but if you're alright with that, I'd push a few minor changes to this PR myself - I'm pretty sure that we could cancel the entity mount offset from getting applied in a way that doesn't involve adding an extra check to that static method.

It was messing with the offsets until I added that check, it seems like the function is triggering before setTranslation is being fed which results in the null value on baseTranslation and doesn't set offsets. But the tricky part here is that it doesn't happen every time and not always on every passenger, so the issue isn't that easy to fix and will likely require lot of testing or you could mess it up quite easily.

If you can't fix it quickly it's best to leave the safety check, this check is not being called that often to mess with performance even at 10k TextDisplay passengers (tested).

[onebeastchris]

I've pushed some smaller cleanup changes (codestyle fixes, removed the hasTranslation variable) - just one final thing, and then this should be good to be merged. Sorry for the wait!

[onebeastchris]

Looks okay now. Thanks!