Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achieve accurate translation y offest with text display as passengers #4440

Closed
alexdev03 opened this issue Feb 11, 2024 · 7 comments
Closed
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.

Comments

@alexdev03
Copy link
Contributor

Describe the bug

Currently, if you add a text display as a passenger to a player, with the right offset you can achieve something like this:
image
But on bedrock since text displays don't exist, there is a workaround with armor stands as passengers to create multi lines.
The translation offest is not handled and with that the lines are inside the skin of the player.

To Reproduce

I made a custom plugin to replace current nametag system: https://github.com/alexdev03/UnlimitedNametags/tree/packet-based

Expected behaviour

On bedrock there should be n more lines based on the text display offest in entity metadata packet (Display#11). Maybe you could find a formula to calculate the number of lines from a float y value.

Screenshots / Videos

image
image

Server Version and Plugins

I'm using geyser velocity and a paper fork 1.20.4 backend.

Geyser Dump

https://dump.geysermc.org/G6hEiqmDkQhRcaRSwPTSzuU0VEPMm20u

Geyser Version

Geyser version 2.2.2-SNAPSHOT (git-master-19c6648) (Java: 1.20.4, Bedrock: 1.20.40/1.20.41 - 1.20.60/1.20.61)

Minecraft: Bedrock Edition Device/Version

1.20.60

Additional Context

No response

@onebeastchris onebeastchris added the Confirmed Bug The bug reported is confirmed and able to be replicated. label Feb 15, 2024
@onebeastchris
Copy link
Member

could you test if #4676 resolves this issue?
You can get a build of that PR in the "checks" tab.

@alexdev03
Copy link
Contributor Author

Hi, it is clearly better, but could you move it a bit more up?
image

@onebeastchris
Copy link
Member

that would likely be related to the offset of the display entity mount itself, and unrelated to that PR :p

@alexdev03
Copy link
Contributor Author

image
Here you can see both java and bedrock

@stromsoftware
Copy link
Contributor

image Here you can see both java and bedrock

I balanced the offset difference in 4503e45

@alexdev03
Copy link
Contributor Author

Now it's clearly better, thanks
image

I think the offset it's enough

@onebeastchris
Copy link
Member

Closing as completed - the latest commit should resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.
Projects
None yet
Development

No branches or pull requests

3 participants