Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature importance from DataFrame #45

Open
GilesStrong opened this issue Jun 4, 2020 · 0 comments
Open

Feature importance from DataFrame #45

GilesStrong opened this issue Jun 4, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority Not urgent and won't degrade with time

Comments

@GilesStrong
Copy link
Owner

Current state

Ensemble and Model classes have get_feat_importance methods to compute the permutation importance of input features. Currently the the input data must be supplied as a FoldYielder object. There are occasions when one may wish to evaluate the feature importance on only a subset of the data (e.g. only on 2-jet events). This then requires saving the subset to a foldfile and instantiating a new FoldYielder to point to the subset of data.

Probable solution

The get_feat_importance methods are extend to take pandas.DataFrame objects as inputs. This will no doubt impact certain aspects of the returned information, such as averaging over folds and computing uncertainties. I think it is reasonable that if the user really wants this extra information, they can export a new foldfile. This extension would simply be for getting the rough information quickly and producing an informative plot which wouldn't necessarily be used for publication.

@GilesStrong GilesStrong added enhancement New feature or request good first issue Good for newcomers low priority Not urgent and won't degrade with time labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority Not urgent and won't degrade with time
Projects
None yet
Development

No branches or pull requests

1 participant