Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecimalParameter not supported on culture not using the point as decimal separator #90

Closed
Seddryck opened this issue Apr 2, 2023 · 2 comments

Comments

@Seddryck
Copy link
Contributor

Seddryck commented Apr 2, 2023

When running current test-suite on a computer with a configuration where the point is not the decimal separator, the following test is failing:

DuckDB.NET.Test.Parameters.DecimalParameterTests.InsertSelectValueTest
   Source: DecimalParameterTest.cs line 39
   Duration: 7 ms

  Message: 
DuckDB.NET.Data.DuckDBException : Conversion Error: Could not convert string "0,5" to DECIMAL(38,15)

  Stack Trace: 
PreparedStatement.Execute(DuckDBParameterCollection parameterCollection) line 67
DuckDbCommand.ExecuteNonQuery() line 68
DecimalParameterTests.<InsertSelectValueTest>g__DecimalTests|1_0(Decimal[] values, Int32 precision, Int32 scale, <>c__DisplayClass1_0& ) line 72
DecimalParameterTests.InsertSelectValueTest() line 45

Also the test DecimalParameterTests.SimpleTest is sensitive to culture.

@Seddryck
Copy link
Contributor Author

Seddryck commented Apr 2, 2023

I'm working on it and will submit a PR.

@Giorgi
Copy link
Owner

Giorgi commented Apr 2, 2023

@Seddryck Thanks!

@Giorgi Giorgi closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants