Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DataFrames deprecation warnings #1384

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

bjarthur
Copy link
Member

Not was introduced in DataFrames 0.19, so all prior versions are incompatible.

should probably wait to merge this until after the Colors issue as been resolved and a release tagged with it.

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #1384 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   90.57%   90.52%   -0.06%     
==========================================
  Files          39       39              
  Lines        3988     4167     +179     
==========================================
+ Hits         3612     3772     +160     
- Misses        376      395      +19
Impacted Files Coverage Δ
src/dataframes.jl 97.56% <100%> (+0.12%) ⬆️
src/geom/rectbin.jl 80.55% <0%> (-6.95%) ⬇️
src/poetry.jl 90.74% <0%> (-5.26%) ⬇️
src/geom/label.jl 96.26% <0%> (-2.74%) ⬇️
src/geom/beeswarm.jl 90% <0%> (-2.65%) ⬇️
src/guide/keys.jl 92.4% <0%> (-2.34%) ⬇️
src/guide.jl 90.64% <0%> (-0.27%) ⬇️
src/aesthetics.jl 81.3% <0%> (-0.22%) ⬇️
src/statistics.jl 96.92% <0%> (-0.01%) ⬇️
src/shapes.jl 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ab673...5683dcc. Read the comment docs.

@bjarthur
Copy link
Member Author

found a way to maintain DataFrame compatibility back to 0.15, so can include this PR in the next release

@bjarthur bjarthur merged commit aec6dad into GiovineItalia:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants