Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK-2409 Add doc to how to update the lockfile #1840

Merged
merged 5 commits into from
Mar 15, 2024
Merged

GSK-2409 Add doc to how to update the lockfile #1840

merged 5 commits into from
Mar 15, 2024

Conversation

kevinmessiaen
Copy link
Member

Description

  • Added doc to how to update the lockfile
  • Removed deprecated formatting instruction (new one hasn't been added since they're part of the pre-commit hook)

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@kevinmessiaen kevinmessiaen requested a review from a team as a code owner March 12, 2024 01:59
Copy link

linear bot commented Mar 12, 2024

@Hartorn
Copy link
Member

Hartorn commented Mar 13, 2024

@kevinmessiaen I think we have an 'update-lock' command in pdm, to do it inside docker (else it may causes issues on MacOs). Maybe the command needs to be updated ?

@Hartorn Hartorn self-requested a review March 13, 2024 08:48
@Hartorn Hartorn assigned Hartorn and kevinmessiaen and unassigned Hartorn Mar 13, 2024
@kevinmessiaen
Copy link
Member Author

@kevinmessiaen I think we have an 'update-lock' command in pdm, to do it inside docker (else it may causes issues on MacOs). Maybe the command needs to be updated ?

Ah yes you're right, I've updated to use the pdm update-lock command instead

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit 6a0c1a3 into main Mar 15, 2024
16 checks passed
@kevinmessiaen kevinmessiaen deleted the GSK-2409 branch March 15, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants