Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSK-3419] Add mixpanel telemetry to new client methods #1875

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[GSK-3419] Add mixpanel telemetry to new client methods #1875

merged 3 commits into from
Apr 4, 2024

Conversation

henchaves
Copy link
Member

Description

This PR adds telemetry to the new methods regarding Multi ML Worker implemented in GiskardClient.

Related Issue

GSK-3419 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear Linear
Copy link

linear bot commented Apr 4, 2024

GSK-3419 Add mixpanel telemetry

@henchaves henchaves self-assigned this Apr 4, 2024
Inokinoki
Inokinoki approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@henchaves henchaves merged commit 1c79757 into multi-ml-worker Apr 4, 2024
15 of 16 checks passed
@henchaves henchaves deleted the feature/gsk-3419-add-mixpanel-telemetry branch April 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

@kevinmessiaen kevinmessiaen Awaiting requested review from kevinmessiaen

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@henchaves henchaves

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henchaves @Inokinoki