Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSK-3419] Add mixpanel telemetry to new client methods #1875

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[GSK-3419] Add mixpanel telemetry to new client methods #1875

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b17422f
Add telemetry to kernel/worker client methods
henchaves Apr 4, 2024
7227e50
Merge branch 'multi-ml-worker' into feature/gsk-3419-add-mixpanel-tel…
henchaves Apr 4, 2024
58f51b1
Update analytics event for initialize_kernel
henchaves Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions giskard/client/giskard_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,15 @@ def initialize_kernel(self, project_key: str):
python_version = f"{sys.version_info[0]}.{sys.version_info[1]}"
kernel_name = f"{project_key}_kernel"

analytics.track(
"Init kernel from env",
{
"project_key": anonymize(project_key),
"kernel_name": anonymize(kernel_name),
Inokinoki marked this conversation as resolved.
Show resolved Hide resolved
"python_version": python_version,
},
)

kernels = self._session.get("kernels").json()
frozen_dependencies = [f"{dist.name}=={dist.version}" for dist in importlib_metadata.distributions()]

Expand All @@ -217,6 +226,15 @@ def initialize_kernel(self, project_key: str):
def create_kernel(
self, kernel_name: str, python_version: str, requestedDependencies: str = "", frozen_dependencies: str = ""
):
analytics.track(
"Create kernel",
{
"kernel_name": anonymize(kernel_name),
"python_version": python_version,
"requestedDependencies": requestedDependencies,
},
)

self._session.post(
"kernels",
json={
Expand All @@ -230,10 +248,12 @@ def create_kernel(
)

def start_managed_worker(self, kernel_name: str):
analytics.track("Start worker", {"kernel_name": anonymize(kernel_name)})
self._session.post(f"kernels/start/{kernel_name}")
logger.info("The worker is starting up")

def stop_managed_worker(self, kernel_name: str):
analytics.track("Stop worker", {"kernel_name": anonymize(kernel_name)})
self._session.post(f"kernels/stop/{kernel_name}")
logger.info("The worker has been requested to stop")

Expand Down
Loading