-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
293 add smoothingfilter cli functions #307
Conversation
Servus Mika, thank you for integrating this into the CLI. I never came across this type of error 🙄 and to be honest, currently have no capacity to dive in. I would probably need to test this out by myself, so is there a doc containing info how to test the CLL implementation or could you provide me a short how to for replicating this on my end? Take your time on this one, since I assume that I cannot check it out prior to week 8. So if you have other functions to implement, I recommend to focus on these and do not wait for my reply the next couple of days. Just for clarifiying my understanding, the Conda fails in the PR:
refer to other files/functions than the filters. That's probably not the issue, right? Cheers, Michael |
Hello Michael, Thank you for looking into this! I'm not sure how familiar you are with these CLI functions so here are (hopefully sufficient) instructions to get you started: You need a virtual environment into which you install
builds the .whl file inside
Note, that every time you create a new CLI function or make any modifications to the existing ones, you need to rebuild the wheel and install it. Now with
you should be able to see all the cli functions available. To get help with any of the CLI functions, just type
To test, e.g., the Frost filter with the default parameters, type
This should give you the same error as it gives to me. The Conda fails shouldn't be related to this as they seem to happen in other PRs as well. @nmaarnio is looking into it. -Mika |
Hi, If you are using Poetry (or Docker) environment, you don't actually need to create any additional venv. Just run
I tried to solve this quickly, but with no success. I could run the notebook without any issues, but the CLI functions give the same error Mika pointed out. It would still probably be worth test this with different Scipy version, although it puzzles me that the functions run in notebooks/scripts with the current version... |
Ahoi, I‘m currently on my way back from traveling and will check that out asap. But I‘ll probably be only 1-2 days in the office this week. Cheers, |
Bug fixes for kuan, frost and lee-enhanced speckle filters. Functions had inconsistent type declarations for n_looks (must be integer) and damping_factor (must be Number or float). That issue apparently confused the CLI calls. Also updated the cli.py to be consistent with the speckle code.
checked this one out today. There were some minor inconsistencies in the respective call- and private function definitions ✍️ , which obviously caused these errors 🛑 for the Cheers and a nice weekend 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Micha! Worked for me, so let's merge these now.
I removed the debug prints and TODO comments Mika had put there before I merge.
Adds cli functions for the filter tools. There is a problem with Lee enhanced, frost and kuan filters which I was unable to solve, hence the draft PR. Could you @msmiyels look into it as you have implemented these tools? Those three filter function all give
SystemError: <built-in function len> returned a result with an exception set
with the same data (small_raster.tif intests/data/remote
) as the tests for these tools use.