Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoothing/filter CLI functions #293

Closed
nmaarnio opened this issue Jan 18, 2024 · 5 comments · Fixed by #307
Closed

Add smoothing/filter CLI functions #293

nmaarnio opened this issue Jan 18, 2024 · 5 comments · Fixed by #307
Labels
CLI Command-line interface related preprocessing Feature related to preprocessing functions

Comments

@nmaarnio
Copy link
Collaborator

No description provided.

@nmaarnio nmaarnio added preprocessing Feature related to preprocessing functions CLI Command-line interface related labels Jan 18, 2024
@nmaarnio
Copy link
Collaborator Author

@msmiyels , I will implement the CLI functions for these tools soon, and I thought it'd be a good idea to think a little bit how these tools will show up in QGIS. There are quite many different tools that fall under this filter category. In QGIS processing algorithms, it is not possible to create groups within groups, and therefore all these tools would show up directly under raster processing.

So I guess what I am after is that do you think it's ok to directly transfer all the public functions of these filter functions to the processing algorithms, or do we want to try to "merge" some tools into one and dividing behaviour with parameters, thus reducing the number of entries in the processing algorithm menu? We could also create a "level 1" group just for these filters, so they wouldn't fall under raster processing in QGIS, this might be a good solution too, if we want to make it cleaner and easier for users to find different tools.

@msmiyels
Copy link
Collaborator

@nmaarnio, good question 🙄. Let me think about it 🤯 and we can catch it up in the weekly on Wednesday?

Question: This would affect the derviatives as well, right?

@nmaarnio
Copy link
Collaborator Author

Yes, I think we could think about the derivates too. And yes, we can discuss these on Wednesday if you think it won't take too long

@msmiyels
Copy link
Collaborator

Huhu,

okay, than I'll vote 🗳 for Wednesday 😉 We should be able to keep it in time ^^

@msorvoja
Copy link
Collaborator

I made cli functions for these filter functions. When testing with the same raster data as the tests for these functions (which pass), I get SystemError: <built-in function len> returned a result with an exception set with Lee enhanced, frost and kuan filters.

@msorvoja msorvoja linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command-line interface related preprocessing Feature related to preprocessing functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants