Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "instance" to "ggshield config get", "unset", and "list" #678

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

agateau-gg
Copy link
Collaborator

This PR is the continuation of #670. #670 added support for ggshield config set instance <NAME>. This PR adds support for ggshield config get instance, ggshield config unset instance and make ggshield config list show the instance.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #678 (60ee5f3) into main (a2cff8d) will increase coverage by 0.02%.
The diff coverage is 96.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   93.00%   93.02%   +0.02%     
==========================================
  Files         128      128              
  Lines        5663     5681      +18     
==========================================
+ Hits         5267     5285      +18     
  Misses        396      396              
Flag Coverage Δ
unittests 93.02% <96.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ggshield/cmd/config/config_get.py 93.33% <85.71%> (+0.74%) ⬆️
ggshield/cmd/config/config_list.py 100.00% <100.00%> (ø)
ggshield/cmd/config/config_set.py 97.36% <100.00%> (+0.14%) ⬆️
ggshield/cmd/config/config_unset.py 100.00% <100.00%> (ø)

@agateau-gg agateau-gg force-pushed the agateau/config-get-unset-list branch from d30e55c to 60ee5f3 Compare August 9, 2023 08:30
@agateau-gg agateau-gg requested a review from Walz August 9, 2023 08:51
@agateau-gg agateau-gg merged commit 610e530 into main Aug 10, 2023
22 checks passed
@agateau-gg agateau-gg deleted the agateau/config-get-unset-list branch August 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants