This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Update CocoaPods and pods #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
commented
Feb 22, 2019
| @@ -572,7 +572,7 @@ IssueManagingContextControllerDelegate { | |||
| case .item(let item): | |||
| guard item is IssueResult else { break } | |||
| updateAndScrollIfNeeded() | |||
| case .list: break | |||
| case .list, .clear: break | |||
There was a problem hiding this comment.
This is a new case in FlatCache.Update.
There was a problem hiding this comment.
I'm assuming this is a "correct" implementation here @rizwankce? :)
BasThomas
commented
Feb 22, 2019
| @@ -19,7 +19,7 @@ final class LocalNotificationsCache { | |||
|
|
|||
| private let path: String | |||
| private lazy var queue: FMDatabaseQueue = { | |||
| return FMDatabaseQueue(path: self.path) | |||
| return FMDatabaseQueue(path: self.path)! | |||
There was a problem hiding this comment.
This now returns an optional; force unwrapping for now, as it seemingly worked in the past without error. 😃
The documentation states "it returns nil in case of an error"
BasThomas
commented
Feb 22, 2019
| @@ -9,6 +9,6 @@ Pod::Spec.new do |spec| | |||
| spec.source_files = 'GitHubAPI/*.swift' | |||
| spec.ios.deployment_target = '11.0' | |||
| spec.watchos.deployment_target = '3.0' | |||
| spec.dependency 'Alamofire', '~> 4.4.0' | |||
| spec.dependency 'Alamofire', '~> 4.8' | |||
There was a problem hiding this comment.
I was a bit confused that we need to update this in the podspec and the Podfile 😅
Feels like one of the two might not be necessary?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.