Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kramdown Class Support #18

Open
skyout opened this issue Apr 16, 2015 · 6 comments
Open

Kramdown Class Support #18

skyout opened this issue Apr 16, 2015 · 6 comments

Comments

@skyout
Copy link

skyout commented Apr 16, 2015

Classes are not being parsed from Kramdown:

This following kramdown:

> text content
{: .class1 .class2 }

should output:

<blockquote class="class1 class2">text content</blockquote>

but instead is outputting:

 <blockquote>text content {: .class1 .class2  }</blockquote>

It should set the classes on the preceding element and not include the markdown class declaration in the content.

On a possibly related note, I am still seeing issue #4 rendering incorrectly while using version 0.4.6.

@AaronO
Copy link
Contributor

AaronO commented Apr 29, 2015

@slanningGH The next kramed release simplifies the internal code, which will make it easier to add full kramdown support, see: #14 (comment)

#4 Shouldn't happen, can you share code that triggers that behavior so we can it to the tests ?

@skyout
Copy link
Author

skyout commented May 6, 2015

I can reproduce #4 with the following code:

# h1 {#class}

this outputs

<h1 id="h1-class-">h1 {#class}</h1>

also, every h1, h2, h3 and so on that I am seeing is setting an ID that matches the content

# This is a header

this outputs

<h1 id="this-is-a-header">This is a header</h1>

@signorekai
Copy link

Can I know if class support has been added?

@AlexanderKozhevin
Copy link

+1

@AndiKod
Copy link

AndiKod commented Feb 8, 2023

2023, installed the package precisely for this, and it looks like the project is no more maintained ...and the main benefit expected (aka Kramdown) will never be available. :(

@chocmake
Copy link

2023, installed the package precisely for this, and it looks like the project is no more maintained ...and the main benefit expected (aka Kramdown) will never be available. :(

That's a pity. Kramdown inline attributes and classes/ids are the key distinguishing advantage of kramdown but from searching around it appears there isn't a Javascript implementation in any Markdown parser to date.

Was looking around for a potential way to augment Jekyll with a solely JS based approach, since a JS implementation of Liquid exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants