Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing travis for D7 #134

Closed
wants to merge 18 commits into from
Closed

Fix failing travis for D7 #134

wants to merge 18 commits into from

Conversation

nirgn975
Copy link

@nirgn975 nirgn975 commented Jul 4, 2016

@@ -13,6 +13,9 @@ before_script:
- cd ../..

# install drush
- pear upgrade –force Console_Getopt
Copy link
Member

@amitaibu amitaibu Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use composer to get Drush, like we have in other projects

@nirgn975
Copy link
Author

nirgn975 commented Jul 5, 2016

@amitaibu Now we have drush (installed with composer) (in d1539c1 I print drush --help to make sure it's installed globally).

But I get a new error:
build__183_-gizra_og-_travis_ci

Any ideas?

@amitaibu
Copy link
Member

amitaibu commented Jul 5, 2016

@ordavidil might know

@amitaibu
Copy link
Member

amitaibu commented Jul 6, 2016

Try copying config from Message - https://github.com/Gizra/message/blob/7.x-1.x/.travis.yml

@ordavidil
Copy link

10x for covering up ...

@nirgn975
Copy link
Author

nirgn975 commented Jul 7, 2016

@amitaibu I looked at this, but couldn't figure it out. There is no scripts/run-tests.sh there.. What file is it run?

@amitaibu
Copy link
Member

amitaibu commented Jul 7, 2016

It runs Drupal core's test-runner. See also RESTful as example.

Better copy and just do the adjustments. php ./scripts/run-tests.sh from Drupal's root should work on your local as-well.

@amitaibu
Copy link
Member

This is a blocking issue - would love t get it fixed.

@nirgn975
Copy link
Author

nirgn975 commented Jul 27, 2016

@amitaibu The tests are working now, but couple of them are fail:
build__196_-gizra_og-_travis_ci

I don't think we should fix them in this PR, am I right?

@amitaibu
Copy link
Member

We actually need to fix it here. Thanks, I'll give it a look.

@amitaibu
Copy link
Member

amitaibu commented Sep 1, 2016

@nirgn975 can you continue looking at this please, and try to figure why it fails. Does it fail on your local as-well?

@amitaibu
Copy link
Member

What's the status here?

@nirgn975
Copy link
Author

@amitaibu Tried to run the tests on my local - without success. And I don't have any idea to why it fails.

@amitaibu
Copy link
Member

I'm able to run the failing tests on my local via the UI. Can you try with this command

@amitaibu
Copy link
Member

closed in favor of #187

@amitaibu amitaibu closed this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants