Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

Merged
merged 4 commits into from Jul 11, 2017
Merged

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

merged 4 commits into from Jul 11, 2017

Conversation

alesrebec
Copy link
Collaborator

Issue #121

@alesrebec
Merge pull request #1 from Gizra/7.x-2.x
f9e77de 
Issue #2151015 by hass, tmckeown, iaminawe: Migrate warnings
@alesrebec
Issue Gizra#121: Added option in og_context_plugin_argument_default_g…
4982107 
…roup_context.inc to accompany the permission rewrite in og_context().
amitaibu
amitaibu reviewed Jun 23, 2016
View reviewed changes
og_context/includes/views/handlers/og_context_plugin_argument_default_group_context.inc
@@ -32,13 +32,21 @@ class og_context_plugin_argument_default_group_context extends views_plugin_argu
'#default_value' => $this->options['group_type'],
'#description' => t('Determine what entity type that group should be of.')
);
$form['check_access'] = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to define it also in option_definition

@alesrebec
Copy link
Collaborator Author

alesrebec commented Jun 23, 2016 •
edited

@amitaibu thanks for the quick review.
For some reason travis ci can't test it right now..
Trying to discover channel pear.drush.org over https:// instead Discovery of channel "pear.drush.org" failed (channel-add: Cannot open "https://pear.drush.org/channel.xml" (Connection to pear.drush.org:443 failed: php_network_getaddresses: getaddrinfo failed: Name or service not known)) The command "pear channel-discover pear.drush.org" failed and exited with 1 during . Your build has been stopped.
https://travis-ci.org/Gizra/og/builds/139718693

The commit with option_definition should be fine though.

amitaibu
amitaibu reviewed Jun 23, 2016
View reviewed changes
og_context/includes/views/handlers/og_context_plugin_argument_default_group_context.inc Outdated
@@ -32,13 +33,20 @@ class og_context_plugin_argument_default_group_context extends views_plugin_argu
'#default_value' => $this->options['group_type'],
'#description' => t('Determine what entity type that group should be of.')
);
$form['check_access'] = array(
'#type' => 'select',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a checkbox

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved.

@alesrebec
Copy link
Collaborator Author

Hope it's fine now.
Looks like all test tests are failing now because of unreachable https://pear.drush.org/channel.xml file.

@amitaibu
Copy link
Member

Lots of karma points, if you'll be able to fix the travis tests in another PR :)

@amitaibu
Copy link
Member

Can you also please attach a screenshot showing the new option.

@alesrebec
Copy link
Collaborator Author

views_og_context_check_access

@amitaibu
Copy link
Member

amitaibu commented Jul 4, 2016

blocked by #133

@alesrebec
Copy link
Collaborator Author

Is this one still blocked?

@amitaibu
Copy link
Member

amitaibu commented Sep 6, 2016

I'm afraid so :/ @nirgn975 is working on #133 - but if you have time to give it a look as-well, it might speed it up.

@alesrebec
Copy link
Collaborator Author

Sorry, don't use Travis so I might be unhelpful with this.
Also we can mark is as blocked by #134. The debate and progress of #133 is all there.

@kyletaylored
Copy link

I recently ran into this issue that needs the disable the check_access, and while I just wrote it into my own Views plugin, I wanted to follow up and check the status on this PR!

@alesrebec
Copy link
Collaborator Author

According to #255 this test can be restarted.
@amitaibu can you restart it so we don't need to open a new PR?

@jorrit
Copy link

jorrit commented Jul 11, 2017

If you amend the commit and force push it Travis will restart the test.

@amitaibu
Copy link
Member

Try to merge with 7.x-2.x, where Travis is now fixed.

@alesrebec
Issue Gizra#121: Changed form element type for check_access from sele…
16be973 
…ct to checkbox and changed description to match the change.
@alesrebec
Copy link
Collaborator Author

It's a pass.

@amitaibu amitaibu merged commit 60d9f3b into Gizra:7.x-2.x Jul 11, 2017
@amitaibu
Copy link
Member

Thanks 👍

@alesrebec
Copy link
Collaborator Author

You're welcome. It's finally in.
You probably need to fix the authorship of all the commits taken from github repo.
https://www.drupal.org/node/13446/commits

@amitaibu
Copy link
Member

Sorry. That's weird, usually the authorship is working correctly when I just push.

@alesrebec
Copy link
Collaborator Author

@amitaibu Any plans to release 7.x-2.10 at DrupalCon Vienna's sprints this week?
There are quite some important patches missing in the current stable version (7.x-2.9) released 5 months from ago.
https://github.com/Gizra/og/commits/7.x-2.x

@amitaibu
Copy link
Member

amitaibu commented Oct 1, 2017

Post DrupalCon, but I'll try to push a new version soon.

@alesrebec
Copy link
Collaborator Author

alesrebec commented Mar 28, 2018 •
edited

Almost shit my pants when I noticed OG 7.x-2.9 is 2 years old in few days.
So many fixes and improvements that were already merged 7.x-2.x are still missing from stable 7.x-2.10 release.
I'm living with patches in this project for a long time now and I'm sure I'm not the only one.
@amitaibu if you need help with it, just say.
We are all 110% busy with work and kids, but we'll risk one night for this. Count me in.

@amitaibu
Copy link
Member

@amitaibu if you need help with it, just say.

@alesrebec I need help :) How about I'll allow you to coordinate this release (and the possible post-release issues) - would you be up for it?

@alesrebec
Copy link
Collaborator Author

Well, I kinda gave my word to help, sooo.. yes, I'm up for it.

@amitaibu
Copy link
Member

amitaibu commented Apr 1, 2018

@alesrebec great! Will you be in the upcoming DrupalCon?

Otherwise, can you ping me via email amitai@gizra.com -- and we'll coordinate this?

@alesrebec alesrebec mentioned this pull request Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alesrebec @amitaibu @kyletaylored @jorrit