Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mess in attributes nbands/count/bands/indexes #280

Closed
adehecq opened this issue Aug 24, 2022 · 0 comments · Fixed by #346
Closed

Fix the mess in attributes nbands/count/bands/indexes #280

adehecq opened this issue Aug 24, 2022 · 0 comments · Fixed by #346
Labels
invalid This doesn't seem right priority

Comments

@adehecq
Copy link
Member

adehecq commented Aug 24, 2022

See the discussion in PR #265 about the craziness in attributes count vs nbands, bands vs indexes.
Here is my suggestion:

I think we should stay consistent with rasterio's naming convention and hence have count and indexes match the definition of rasterio:

  • count: band count on disk
  • indexes: The 1-based indexes of each band in the dataset

We can have an equivalent of each for bands loaded, i.e. count_loaded and indexes_loaded (not sure the latter is really needed...).
What do you think @erikmannerfelt, @atedstone @rhugonnet ?
Others should be deprecated.

Originally posted by @adehecq in #265 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority
Projects
None yet
2 participants