Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could coreg/pipelines.py get a different name? #405

Closed
erikmannerfelt opened this issue Aug 16, 2023 · 3 comments · Fixed by #424
Closed

Could coreg/pipelines.py get a different name? #405

erikmannerfelt opened this issue Aug 16, 2023 · 3 comments · Fixed by #424

Comments

@erikmannerfelt
Copy link
Contributor

As you may notice, I'm only now starting to catch up with all of the changes that happened in the spring! I love the new structure in general but got very confused when looking for the CoregPipeline class, as my intuition led me to check the pipelines.py file.

I unfortunately don't have a great suggestion for what it could be called instead. Here are some random ideas:

  • workflows
  • default_workflow
  • processing
  • aio (all-in-one)
  • fast (or a synonym, since it's made for quick-and-dirty-no-think co-registration)

I think "default_workflow" is the least worst suggestion in my opinion. What do you think, @adehecq , @rhugonnet ?

@erikmannerfelt erikmannerfelt changed the title Could ´coreg/pipelines.py` get a different name? Could coreg/pipelines.py get a different name? Aug 16, 2023
@rhugonnet
Copy link
Contributor

I agree, I also found it a bit confusing when naming it pipelines, but didn't have many other ideas!

My favorite is workflows 😄 (it will not be a public module, so as long as it's clear for us it's sufficient!)

@erikmannerfelt
Copy link
Contributor Author

I like workflows.py too! What do you think @adehecq ?

@adehecq
Copy link
Member

adehecq commented Sep 6, 2023

Just reading this once the change has been implemented, but "workflows" is nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants