applet.program.stusb4500_nvm: Import new applet to program STUSB4500 NVM #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Apr 14, 2023
| @@ -0,0 +1,199 @@ | |||
| # Reference: STSW-STUSB004 Documentation | |||
There was a problem hiding this comment.
Could you upload this to the archive please?
There was a problem hiding this comment.
Will do. Didn't even see the archive before.
smunaut
commented
Apr 14, 2023
|
|
||
| async def disable(self): | ||
| result = await self._write_regs(self.FTP_CTRL_0, [0x40, 0x00]) | ||
| result = result and await self._write_regs(self.FTP_KEY, self.FTP_KEY_VALUE) |
There was a problem hiding this comment.
Arf, actually just noticed this should have been 0x00 value ... (to remove the "magic value" from the register).
Doesn't impact functionality (which is why I didn't notice) but I'll push a new version with that fixed tomorrow.
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
|
Fixed the "disable" method and added the archive accession number |
whitequark
approved these changes
Apr 15, 2023
|
Thanks for the nice applet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.