Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Go Fish Mod #26

Closed
sweetsosweet opened this issue Sep 12, 2021 · 3 comments
Closed

Crash with Go Fish Mod #26

sweetsosweet opened this issue Sep 12, 2021 · 3 comments
Labels
incompatibility This bug happens due to a mod incompatibility

Comments

@sweetsosweet
Copy link

I guess these two mods are not compatible? Both load on their own.

Here's the mod test list:

  • cloth-api-2.0.54
  • cloth-config-5.0.38-fabric
  • fabric-api-0.39.2+1.17
  • go-fish-1.3.0-beta-1.17.1
  • levelz-1.0.7

(also tried later with fabric-api-0.40.1+1.17)

Here's my log: https://gist.github.com/sweetsosweet/d22154f3dd934b79279323fe6a973295

@Globox1997
Copy link
Owner

Yes, for some reason Draylar uses an Overwrite inside the FishingRodItem class on the use method which makes it incompatible with all other mods which try to inject stuff into the same method. It doesn't need to be an Overwrite but that is not in my hands.
Here:https://github.com/Draylar/go-fish/blob/master/src/main/java/draylar/gofish/mixin/FishingRodPropertyMixin.java

@sweetsosweet
Copy link
Author

Ok, thank you, I'll bring this issue to Go Fish.

@Globox1997 Globox1997 added the incompatibility This bug happens due to a mod incompatibility label Dec 28, 2021
@Globox1997
Copy link
Owner

Since Draylar doesn't look like he is gonna change anything in this method (which would be simple ;) ), I removed the mixin when this mod is loaded with 3c829c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility This bug happens due to a mod incompatibility
Projects
None yet
Development

No branches or pull requests

2 participants