Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with BCLib, Reforged button on anvil doesn't work #11

Closed
ConqAra opened this issue Jun 25, 2022 · 13 comments · Fixed by #16
Closed

Incompatibility with BCLib, Reforged button on anvil doesn't work #11

ConqAra opened this issue Jun 25, 2022 · 13 comments · Fixed by #16
Labels
incompatibility This bug happens due to a mod incompatibility

Comments

@ConqAra
Copy link

ConqAra commented Jun 25, 2022

I'm trying to click on the reforge button in the anvil menu and it just doesn't work.

@ConqAra
Copy link
Author

ConqAra commented Jun 25, 2022

May have to do something with a mod incompatibility? I can send my log but i dont see an error for this.

Log: https://paste.ee/p/3InhH

@Globox1997
Copy link
Owner

Mh this is pretty bad, the good thing is you only have quadrillion mods installed xD
I have no idea what could cause this issue, maybe a screen editing mod

@Leonelecg
Copy link

I have the same problem, and I found out why, I guess it's an incompatibility with BCLib

Here is the BCLib curseforge link: https://www.curseforge.com/minecraft/mc-mods/bclib

@ConqAra ConqAra changed the title Reforged button on anvil doesn't work Incompatibility with BCLib, Reforged button on anvil doesn't work Jul 4, 2022
@jklw10
Copy link

jklw10 commented Jul 15, 2022

Can confirm, button doesn't work and I do have BCLib but I cannot know if that's the one mod that causes this. I'm unsure because i don't know if bclib itself changes the anvil menu in any way?

@Globox1997
Copy link
Owner

If you guys can narrow down the incompatibility, that would be super helpful :)
I will look into it when I have time for modding again

@Leonelecg
Copy link

I'm pretty sure BCLib is what's causing the error, maybe some kind of incompatibility

@jklw10
Copy link

jklw10 commented Jul 22, 2022

I think a good temporary fix would be to add a keybind to switch to reforge screen...

@Globox1997
Copy link
Owner

Pretty sure this is the issue: https://github.com/paulevsGitch/BCLib/blob/main/src/main/java/ru/bclib/mixin/common/AnvilMenuMixin.java#L180
BCLib overrides the onclick method (different mappings) so the tiered injection won't get used
Can't make it compatible from my side, except adding a keybind which sucks

@jklw10
Copy link

jklw10 commented Jul 23, 2022

hmm i assume you'll open an issue for it then. or just make a pull request with it being an injection instead of override.

@Globox1997
Copy link
Owner

I assume you will open an issue :)

@itsdinkd
Copy link

itsdinkd commented Jul 27, 2022

You guys are lazy! I'll open the issue.

@itsdinkd
Copy link

I assume you will open an issue :)

Please respond to the developer in the ticket I opened on their github. It's linked here

@kleonaut
Copy link

Please address this

Any plans of applying these fixes to 1.18.2?

Yes, but there is no ETA as it currently has low priority. As far as I can tell, TieredZ can just change the mixing priority to override ours. Which should be absolutely fine. Our mixing is there to show UI in case there are multiple recipes for the same list of ingredients. I think that is not uses in 1.18.2 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility This bug happens due to a mod incompatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants