Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge closed Glowstone pull requests #55

Closed
3 of 8 tasks
deathcap opened this issue May 9, 2015 · 4 comments
Closed
3 of 8 tasks

Merge closed Glowstone pull requests #55

deathcap opened this issue May 9, 2015 · 4 comments

Comments

@deathcap
Copy link
Contributor

deathcap commented May 9, 2015

split off from #6:

  • Already added #191 Difficulty setting in glowstone.yml
  • Already added by entities-ecs, to be merged #196 Gravity for entities
  • #211 Chest sounds and animations
  • #225 SIGTERM handling
    Note: Changes are needed to quickly handle the SIGTERM, instead of doing the normal shutdown process.
  • #226 Damage
  • Functionality already added #237 Inventory windows for all inventory blocks
  • #242 Variable block sounds
  • #272 Prevent illegal placement
  • Not valid #274 getItemInHand()
  • Functionality already added #286 Ore generation
  • Already added by entities-ecs, to be merged #282 Entities
  • Functionality #373 Player.isOnline()
  • Functionality already added #381 Redstone
    Note: the main redstone PR has features the subsequent split ones do not. It would be preferable to add stuff in this PR that are not in the future PRs.
  • Not valid #386 Chat color
  • #391 Network unit tests
  • Functionality already added #436 Basic Redstone support
  • Functionality already added #439 Redstone buttons and levers
  • #483 Configurable messages
  • Not valid #515 Space between > and command
  • Functionality already added #518 Fixes errors on join on a whitelist or ban
  • Not valid #587 Fix console check in headless environments
  • #624 IO utils can load a world without a server

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@gabizou
Copy link
Contributor

gabizou commented Aug 10, 2015

BTW, the old code is up for grabs on the (almost completed) implementation of all living entities with this pr.

@mastercoms
Copy link
Member

I also saw your entities-ecs branch. Would that be better to merge over your main entities branch?

@gabizou
Copy link
Contributor

gabizou commented Aug 23, 2015

I also saw your entities-ecs branch. Would that be better to merge over your main entities branch?

We never got ECS to work, and even then, it's not a real ECS system. Ultimately, it's up to you guys, but I'd rather a quasi component system attached to entities to make the implementation work, and a bunch of systems to work with it.

@mastercoms
Copy link
Member

Hmm ok. I guess I can merge the entities branch and then we can get ecs or a component system working later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants