[WIP] Ran a Node script to remove the damage property from the recipes.yml.… #1073
Conversation
… Did not change anything else.
|
|
|
Building has failed as I haven't updated code to suit the new format. |
My bad. Will fix. |
|
I've updated the result. |
|
The YML parser seemed to have messed up re-serializing some of the arrays and they are now just keyed maps, am fixing. |
… normal arrays, causing an error. This is fixed here.
…e now updated. Also along is the updated version of CraftingManager which sets some flags in the item maps to tell Bukkit that we're not using legacy Material names which was the other half of the errors. This system is a little messy so we should switch over to using the Mojang provided recipes.json or whatever it is ASAP.
| furnaceRecipes.add( | ||
| new FurnaceRecipe(key, resultStack, inputStack.getType(), | ||
| inputStack.getDurability(), xp, 200)); | ||
| //float xp = ((Number) data.get("xp")).floatValue(); // NON-NLS |
There was a problem hiding this comment.
Seems like xp was removed from the original recipes.yml. Is that intentional? If not, could you add it back?
| ItemStack inputStack | ||
| = ItemStack.deserialize((Map<String, Object>) data.get("input")); // NON-NLS | ||
| = ItemStack.deserialize((Map<String, Object>) data.get("input")); // NON-NLS; |
|
@birbe could you possibly send us the Node script under a compatible license for us to continue this work? |
|
I probably won't be able to find it; I might be able to rewrite it though. |
|
Ok, if you could do that, it would be most helpful. Thank you! |
|
Oof, really sorry to leave you hanging like this. I got the script; I'm cleaning up my computer and I found it, not sure if it's still relevant. As for the license: I donate the attached files and code as a part of the GlowstoneMC project, you may use it however you'd like. |
|
Thanks so much! |
Removed the damage property from the recipes with a Node script. This also makes it easier to deal with as in many places we no longer return a map that includes a material along with its damage but simply the material namespaced key alone.
Someone still needs to remove the non-existent blocks from the recipes.