New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random target selector - Fixes #574 #575

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@kaenganxt
Member

kaenganxt commented Oct 18, 2017

This PR fixes the IndexOutOfBoundsException when using the @r selector on a single player as stated in #574.

The commit also reuses the random object for performance reasons.

@momothereal momothereal merged commit 62f43a2 into GlowstoneMC:master Oct 19, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@momothereal

This comment has been minimized.

Show comment
Hide comment
@momothereal

momothereal Oct 19, 2017

Member

Thank you for your contribution!

Member

momothereal commented Oct 19, 2017

Thank you for your contribution!

@kaenganxt kaenganxt deleted the kaenganxt:randomTargetSelector branch Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment