Implement donkey, mule & llama inventories #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into chestedHorse
aramperes
requested changes
Mar 18, 2018
| /** | ||
| * Creates and sets a new inventory, and copies equipment over from the existing inventory. | ||
| */ | ||
| protected abstract void createNewInventory(); |
There was a problem hiding this comment.
I think this should return <InventoryT>, and the constructor should set the inventory field to the return value. The method implementations shouldn't have to update the field imo.
| import org.bukkit.inventory.ItemStack; | ||
| import org.bukkit.inventory.LlamaInventory; | ||
|
|
||
| public class GlowLlamaInventory extends GlowInventory implements LlamaInventory { |
|
|
||
| public abstract class GlowChestedHorse extends GlowAbstractHorse implements ChestedHorse { | ||
| /** | ||
| * A quadruped whose inventory may include a chest. |
There was a problem hiding this comment.
quadruped -> horse
"Quadruped" is too broad
|
Superseded by #872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #864