Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to use tool hygiene #23

Closed
3 tasks
nappex opened this issue Jan 1, 2022 · 7 comments · Fixed by #84
Closed
3 tasks

Consider to use tool hygiene #23

nappex opened this issue Jan 1, 2022 · 7 comments · Fixed by #84

Comments

@nappex
Copy link
Collaborator

nappex commented Jan 1, 2022

This article advise to use at the start of each elixir project tools for control the quality of code.

basic tool for check:

  • mix format
  • mix credo --strict
  • mix dialyzer

We can use all tools above in one with name hygiene with command mix hygiene.

@Glutexo
Copy link
Owner

Glutexo commented Jan 3, 2022

As mentioned in #22 (comment), a pre-commit hook may become handy here.

@nappex
Copy link
Collaborator Author

nappex commented Jan 3, 2022

I didn't know about pre-commit I am going to study it

@Glutexo
Copy link
Owner

Glutexo commented Jan 21, 2022

Also now having a GitHub action, the tools mentioned above may be used for server-side linting too.

@Glutexo Glutexo added the tools label Jan 24, 2022
@Glutexo
Copy link
Owner

Glutexo commented Feb 7, 2022

I’d like to do this as soon as possible.

@Glutexo
Copy link
Owner

Glutexo commented Feb 20, 2022

The codebase is now formatted with mix format. Time to add to CI.

@Glutexo
Copy link
Owner

Glutexo commented Mar 26, 2022

Let’s add mix format first and then experiment with the other tools.

@nappex
Copy link
Collaborator Author

nappex commented Mar 27, 2022

Sources:

    - name: Run Credo
      run: mix credo --strict

https://hashrocket.com/blog/posts/build-the-ultimate-elixir-ci-with-github-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants