Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGui Docking Support #34

Closed
cshenton opened this issue Oct 9, 2020 · 3 comments · Fixed by #51
Closed

ImGui Docking Support #34

cshenton opened this issue Oct 9, 2020 · 3 comments · Fixed by #51

Comments

@cshenton
Copy link

cshenton commented Oct 9, 2020

What would need to be done to support ImGui docking?

Upstream, cimgui appears to have a docking branch, so I imagine it's just a matter of updating the Yggdrasil build script to target the appropriate commits of ImGui and cimgui. However, where I get a bit lost is on how to connect everything together.

Should someone hoping to add this support create PRs in Yggdrasil, CimGui_jll, and this repo? Should those PRs all target a separate branch, or should Yggdrasil's PR target master but in a different subfolder?

@Gnimuc
Copy link
Owner

Gnimuc commented Oct 9, 2020

Should someone hoping to add this support create PRs in Yggdrasil, CimGui_jll, and this repo?

Only PRs to Yggdrasil and this repo are needed. If you submit a PR to Yggdrasil, XXX_jll will be automatically published or updated.

Should those PRs all target a separate branch, or should Yggdrasil's PR target master but in a different subfolder?

In a different subfolder.

I considered adding docking support a while ago, the main problem is versioning. If we maintain two branches, what version should be used for the docking branch?

@wsphillips
Copy link

I think docking and table branches are considered WIP to be eventually added to mainline imgui anyhow?

@Gnimuc
Copy link
Owner

Gnimuc commented Oct 12, 2020

It looks like the table branch will be merged in the near future, but the docking/viewport branch is still relatively unstable and blocked by a few issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants