Replaced pycrypto with pycryptodome #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Res260
reviewed
Jul 4, 2019
Res260
approved these changes
Jul 5, 2019
xshill
requested changes
Jul 22, 2019
|
Done! Should be good now @xshill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had many reason to replace pycrypto with pycryptodome. First, it hasn't been supported in 4-5 years, and second it blocks #127.
The only "downside" with pycryptodome is that we cannot use raw RSA to encrypt and decrypt. Since it is considered unsafe to encrypt/decrypt without padding, they removed the ability to do so, but it is needed for the "RDP" security level. I took the logic behind the original pycrypto RSA module, and made a new class out of it with the required functions.
I've tested most of the different use case, and everything works as intended 🎉