Buggy font shorthand

[GoalSmashers]

See discussion in #134.

[XhmikosR]

So basically, font isn't optimized regarding 400/700, right?

[GoalSmashers]

It is unless all optional values are given, e.g. font: bold normal normal 13px Arial;

On Sep 29, 2013, at 14:05, XhmikosR notifications@github.com wrote:

So basically, font isn't optimized regarding 400/700, right?

—
Reply to this email directly or view it on GitHub.

[Elexy]

Cool, tnx guys!

[GoalSmashers]

Sure, anytime! PR for clean-css-brunch is here: brunch/clean-css-brunch#6

[smschrader]

There is an issue with how clean-css "interprets" the short hand css font property still.
For example in my case the shorthand

font: 11px/normal sans-serif;

got converted to

font: 11px/400 sans-serif;

setting

shorthandCompacting: false

had no effect either.

[XhmikosR]

@GoalSmashers @jakubpawlowicz: the font minification should take into account the case where line-height is set to normal.

[jakubpawlowicz]

I can't see this error happening in any of the latest 3.x branches. Which version do you use, @smschrader?

[XhmikosR]

Indeed, I can confirm this doesn't happen with the latest version.

[smschrader]

@jakubpawlowicz I'm using gulp-minify-css which is at

"version": "1.1.6"

Which has a dependency of clean-css

"clean-css": "^3.3.1"

My current version of clean-css in the build is

"version": "3.3.6"

[jakubpawlowicz]

So that's the latest version and it should be OK. I wonder if there's anything else in your gulp chain that is breaking it.