Remove unit from 0rem

[XhmikosR]

I just noticed this, we need to test it works as expected.

[GoalSmashers]

It should be fine but let's check it (+ how it behaves in IE<9 which do not support rems).

[tomByrer]

note: If you happen to also remove % from 0%, please ensure it does not drop the symbol from 0% { transform:. It will cause world-flooding (ok just some confused/mad programmers)

[XhmikosR]

@tomByrer: it's irrelevant to this... Plus, #182

[GoalSmashers]

@tomByrer we'll make sure!

[GoalSmashers]

@XhmikosR the scenario re IE<9 I was thinking about is as follows:

div { margin: 100px }
…
div { margin: 0rem }

on IE<9 2nd declaration will be dropped thus div will have a margin of 100px, however if we turn 0rem to 0 the 2nd declaration will be taken into account thus margin will be 0.

This is unlikely however we may need a switch to disable it. Thoughts?

[XhmikosR]

That's an edge case indeed; a switch sounds good. But in order not to bloat the options, how about renaming selectors-merge-mode to a more universal name and put this in there too?

[GoalSmashers]

Yup, we should one general - "IE<9 compatibility mode".

[GoalSmashers]

@XhmikosR feel free to give f-rems-186 branch a try. It should be all good.

[XhmikosR]

Looks good but maybe you could make an improvement for the compatibility option.

If no fallback is specified, remove the unit as usual.

[GoalSmashers]

@XhmikosR Maybe I'm missing something but if no compatibility option is given then units will be removed as before.

[XhmikosR]

I mean the case when compatibility is specified and there's no fallback. In that case it makes sense to remove the unit, right?

[GoalSmashers]

Good point, there should be.

[GoalSmashers]

This should be fine now.

[XhmikosR]

I can try it tomorrow again and let you know, but if it works for you I see why it wouldn't for me too 👍

[GoalSmashers]

That's a minor thing so let me merge it. Thanks for taking a look at the code!