Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options.baseRelativeTo was not defined #236

Closed
wants to merge 1 commit into from
Closed

options.baseRelativeTo was not defined #236

wants to merge 1 commit into from

Conversation

alexeyraspopov
Copy link

I think it was just small typo

@GoalSmashers
Copy link
Contributor

@alexeyraspopov thanks for raising this issue. I decided to fix it via a different commit since:

  1. It was actually a bug!
  2. Needed a proper test case to close it.

@alexeyraspopov
Copy link
Author

Sorry, I had no time for writing a test case. Bug was detected by console.log-like debugging. Thanks for the fix

@GoalSmashers
Copy link
Contributor

No worries, you got covered :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants