Bounding volumes refactoring #7
Labels
applied
everything that is not directly related to the math or physics, if it's CI fix, CMake fix etc
refactoring
just rewriting old code
Bounding volumes classes over at
Arion/include/Arion/BoundingVolumes.hpp
andArion/sources/BoundingVolumes.cpp
need some refactorings and optimizations:indices
tofaces
inMesh
struct -- this just makes more sense for that field;Mesh mesh
andstd::set<std::size_t> indices
fields -- they are very often passed around in tandem, so that would be convenient;OrientedBoundingBox::Box
), private and rename them to something more sensible (likeOBBData
in the case ofOrientedBoundingBox
) -- they are only used inside those classes;OrientedBoundingBox
exceptm_boxShape
are not used anywhere outside the constructor) -- right now this calculation data is still stored after constructor finishes execution.Note: this issue was carried over from here in Pegasus repo.
The text was updated successfully, but these errors were encountered: