Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 3.4 compatibility #17

Closed
KANAjetzt opened this issue Jan 6, 2023 · 1 comment
Closed

Godot 3.4 compatibility #17

KANAjetzt opened this issue Jan 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@KANAjetzt
Copy link
Member

Ste — Today at 00:24
Ugh we have one break between 3.4 and 3.5.. mod_log uses Time which does not exist in .4 (OS is used instead)

  • Maybe we can progressively enhance by checking if the Time Class exists
  • If not we can just use OS.get_datetime() in 3.4 and 3.5

_Dictionary get_time ( bool utc=false ) const

Deprecated, use Time.get_time_dict_from_system instead.

Returns current time as a dictionary of keys: hour, minute, second.
https://docs.godotengine.org/en/stable/classes/class_os.html#class-os-method-get-datetime


@KANAjetzt KANAjetzt added this to the v2.1.0 milestone Jan 10, 2023
@KANAjetzt KANAjetzt self-assigned this Jan 10, 2023
@KANAjetzt KANAjetzt added the enhancement New feature or request label Jan 10, 2023
@KANAjetzt
Copy link
Member Author

We ditch 3.4 support - dome keeper will be updated to 3.5 in then near future and the likeliness of games using 3.4 is very small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant