Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function pointer doesn't work for both hand tracking and controllers #180

Open
goatchurchprime opened this issue Aug 23, 2022 · 2 comments

Comments

@goatchurchprime
Copy link
Contributor

The default active_button is VR_TRIGGER.
https://github.com/GodotVR/godot-xr-tools/blob/master/addons/godot-xr-tools/functions/Function_pointer.gd#L27

However, when the system converts to hand tracking, the standard index-finger-to-thumb gesture comes in as VR_BUTTON_4.

This means this feature needs to accept at least two button codes, or the hand tracking module should return code VR_TRIGGER for this gesture.

@BastiaanOlij
Copy link
Member

Hmmm, my gut feeling is that it makes most sense if the hand tracking returns VR_TRIGGER seeing we'd have similar compatibility issues moving between controller and hand tracking...

@BastiaanOlij
Copy link
Member

In OpenXR 1.0.28 this was added: https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#XR_EXT_hand_interaction

We'll soon add support for that upstream and this will allow the action map to drive XR Tools when hand tracking is active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants