Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Steward Profile UI #44

Closed
benefacto opened this issue Nov 30, 2023 · 5 comments
Closed

Implement Steward Profile UI #44

benefacto opened this issue Nov 30, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request P1 - High Important issues that should be resolved soon.

Comments

@benefacto
Copy link
Collaborator

benefacto commented Nov 30, 2023

Business Description

The primary goal is to implement the profile interface for Stewards in the platform. This enhancement focuses on providing Stewards with a comprehensive view of their financial activities and contributions. By integrating key financial statistics into the profile page, we aim to offer Stewards a deeper insight into their impact and engagement within the platform.

image

Key Features and Benefits

  1. Rich Profile Information: Incorporating elements like profile pictures (sourced from NFT images), names, and other relevant data, enriches the Steward's profile, making it more personalized and engaging.

  2. Financial Activity Overview: The interface will display crucial financial metrics such as the number of collectives the Steward has received payments from, total actions performed, and cumulative amounts received. This provides Stewards with a clear and concise summary of their financial engagements.

  3. Contribution Tracking: Stewards will be able to track their donations and the impact they have made. The profile will show the total amount donated and the number of collectives or individuals they have supported, highlighting their contribution to the community.

  4. Data Accuracy and Integration: Ensuring the accuracy of the data displayed is paramount. This will involve integrating with the existing subgraph data structure efficiently.

  5. Improved Engagement: By providing Stewards with detailed insights into their activities and contributions, we aim to enhance their engagement and satisfaction with the platform.

Expected Outcome:

  • Stewards will have access to a more detailed and informative view of their financial activities and contributions on their profile.
  • The updated interface will enhance the overall user experience, potentially increasing engagement and satisfaction among Stewards.

Technical Implementation

Implement new profile interface for Stewards to display key financial statistics, leveraging data already available in the subgraph and contracts. This feature aims to provide Stewards with insightful and detailed information about their activities and contributions. This should be added to the WalletProfilePage here.

Details

  • imageUrl The URL of the NFT's image to display as a profile picture
  • firstName Possibly from NFT metadata
  • lastName Possibly from NFT metadata
  • collectivesTotal The number of collectives the steward has received payments from, something like:
steward(id: "") {
   collectives {
     id
   }
}
  • actionsPerformed Display the total count of actions performed executed, something like:
  steward(id: "") {
    actions
  }
  • amountReceived Present the cumulative amount paid out to said steward, something like:
  steward(id: "") {
    collectives {
      contributions
    }
  }
  • creationDate When the profile was created. This might require a subgraph change as it's not present in the schema, currently.
  • amountDonated The amount the steward has donated, something like:
  donor(id: "") {
    contribution
  }
  • peopleSupported The number of collectives/stewards supported, something like
  donor(id: "") {
    collectives {
      id
    }
  }
  • collectives The collectives the steward has received payments from, something like:
  steward(id: "") {
    collectives {
      id
    }
  }

Notes

  • The required data should be already available may not be already present in the subgraph (unknown modifications may be required); ensure proper querying and integration.
  • Focus on a user-friendly and informative design to enhance the Steward's engagement with their profile.
  • Testing should include validation of data accuracy and UI responsiveness.

Estimate

Estimating the time, especially considering potential unknown modifications to the subgraph, involves a degree of uncertainty.

  1. Requirement Analysis and Planning (4-6 hours): Understanding the detailed requirements of the profile UI, including the financial statistics to be displayed, and assessing the subgraph's current configuration.

  2. Subgraph Assessment and Modification (8-15 hours): If modifications to the subgraph are required (which seems likely based on comments), this could include analyzing the existing schema, implementing necessary changes, and testing these changes. The time could vary significantly based on the complexity of the required changes.

  3. Implementation (20-30 hours):

    • Front-End Development (12-18 hours): Developing the new profile interface, including elements like profile pictures, financial metrics, contribution tracking, etc.
    • Integration with Subgraph and Contracts (8-12 hours): Implementing the logic to fetch and display data from the subgraph and any relevant smart contracts, considering the new or modified subgraph schema.
  4. Testing and Debugging (12-18 hours): Comprehensive testing to ensure data accuracy, responsiveness of the UI, and smooth integration with existing systems. This includes testing the new or modified subgraph integrations and ensuring the UI displays the data correctly.

  5. Review and Refinement (4-6 hours): Addressing any feedback, and refining the feature as needed.

Adding these up, the total estimated time could be around 48-75 hours. This estimate assumes the developer is proficient in the relevant technologies and that there are no significant roadblocks or external dependencies that could delay the project.

@benefacto benefacto added enhancement New feature or request question Further information is requested P1 - High Important issues that should be resolved soon. labels Nov 30, 2023
@benefacto benefacto self-assigned this Nov 30, 2023
@benefacto benefacto changed the title Update Steward Profile UI: Display Steward Payment Statistics Implement Steward Profile UI Dec 5, 2023
@benefacto benefacto removed the question Further information is requested label Dec 5, 2023
@sirpy
Copy link
Contributor

sirpy commented Dec 6, 2023

@benefacto
As i've stated elsewhere I do not believe the subgraph is correctly configured

@decentralauren
Copy link

Hi @benefacto !

  • The business description sounds accurate - there is nothing in there that looks new or incongruent with the prototype and requirements shared prior.
  • The only distinction missing is that what is displayed is a Wallet Profile, and the wallet holder's activities are broken down into Stewardship activities (money they have received from various GoodCollective pools) and Donor activities (money they have given to various GoodCollective pools)
  • I do not have the technical expertise to comment on the Technical Implementation or Estimates, though was under the impression that most of the UI for the wallet profile has already been built. So I defer to @sirpy to provide feedback on these items (looks like you were discussing already).
  • It also looks like the Estimates are a bit off - for example the low end should be 48 hours (if I add up all of the low-end of your estimates).

@benefacto
Copy link
Collaborator Author

  • It also looks like the Estimates are a bit off - for example the low end should be 48 hours (if I add up all of the low-end of your estimates).

Good catch, fixed it!

@krisbitney
Copy link
Collaborator

I believe this is complete. Please QA when you can @vldkhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 - High Important issues that should be resolved soon.
Projects
None yet
Development

No branches or pull requests

5 participants