Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a false positive for ARIA [role = "doc-endnotes"]? #12432

Closed
andreseduardop opened this issue May 3, 2021 · 6 comments · Fixed by #13814
Closed

Is this a false positive for ARIA [role = "doc-endnotes"]? #12432

andreseduardop opened this issue May 3, 2021 · 6 comments · Fixed by #13814
Assignees
Labels
dependencies Pull requests that update a dependency file P1.5

Comments

@andreseduardop
Copy link

Lighthouse encounters the following Accessibility error:
"Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children."
On the page: https://lectupedia.com/en/number-of-books-read-in-each-country/

However, the page contains a <section> with role="doc-endnotes" and several children of type <li> with role="doc-endnote"

@adamraine
Copy link
Member

I am noticing this with the Axe extension as well so we should move this issue to https://github.com/dequelabs/axe-core. I think dequelabs/axe-core#2759 captures a similar bug.

Interestingly, I came across this which says the violation should be ignored.

@andreseduardop
Copy link
Author

Thanks, @adamraine

@davidmerfield
Copy link

davidmerfield commented Sep 20, 2021

I'm unsure why this was closed – the issue does not seem to be solved – although I understand it's a problem with a dependency. At the moment Lighthouse will complain if you pass it the example copied directly from the W3C spec:

<section role="doc-endnotes">
   <h2>Notes</h2>
   <ol>
      <li id="6baa07af" role="doc-endnote">Additional results of this study can be found at … </li>
      <li id="7b2c0555" role="doc-endnote"></li></ol>
</section>

image

@schnerring
Copy link

The docs linked to the error reference version 1.1 of the ARIA specification which states:

The doc-endnote and doc-bilbioentry roles are being deprecated due to their incompatibility with the core ARIA inheritance model for roles (i.e., ARIA’s list role cannot be satisfied by list item roles in a module)

Does Lighthouse adhere to the 1.1 spec?

@adamraine
Copy link
Member

adamraine commented Jan 11, 2022

Looks like the issue will be closed in axe-core 4.4. We will need to bump our dep when that is released.

@Seirdy
Copy link

Seirdy commented Apr 3, 2022

Looks like the issue will be closed in axe-core 4.4. We will need to bump our dep when that is released.

@adamraine Axe 4.4.1 has been released, and deprecates doc-endnote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file P1.5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants