Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse Treemap webpage is missing html lang attribute #12730

Closed
2 tasks done
coliff opened this issue Jul 1, 2021 · 1 comment · Fixed by #13454
Closed
2 tasks done

Lighthouse Treemap webpage is missing html lang attribute #12730

coliff opened this issue Jul 1, 2021 · 1 comment · Fixed by #13454
Assignees
@paulirish
Labels
bug needs-priority

Comments

@coliff
Copy link
Contributor

coliff commented Jul 1, 2021

FAQ

URL

https://account.trimblemaps.com

What happened?

The JavaScript treemap offered to translate the page from Maltese to English for me. The page is missing lang="en" attribute. Maybe that should be added to the <html> at the top. I'm using Edge 91 on Windows 10

image

What did you expect?

It shouldn't offer to translate the page to English.

What have you tried?

No response

How were you running Lighthouse?

Chrome DevTools

Lighthouse Version

8.0.0

Chrome Version

No response

Node Version

No response

Relevant log output

No response
@coliff coliff added the bug label Jul 1, 2021
@coliff
Copy link
Contributor Author

coliff commented Jul 1, 2021

Fun! You can run Lighthouse on the Lighthouse Treemap.

https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Fgooglechrome.github.io%2Flighthouse%2Ftreemap%2F%3Fgzip%3D1%23H4sIAAAAAAAACq2Uy4rbMBSGXyUIunMcyXcFSqEM3XWVZlW6OJZkR1NZciW5IYS8e2VnhlLHKellYbDO5f%2F%2BIwmdkTpYtD0jK74NwnnB91ahLTp437vtZgOMmUH72FvZ1Up00LuYmW6jTCv1Oyv8YHXoePsm%2BcDBHWoDlqMINVKD%2Bi9KMHDp3ejQMSt7v%2FZWjM1rDh7GsOQBspSLkJdeiZDdTdnVp2t29XTNcnHtkkaHmr0TfNUYu3rRWEHfhyLHjA0SelDqZfEkXa%2Fg9NHwUVrq0NOBl9%2FFJOlBqsmtP%2FVjfuZIh66Q%2FnxGGjrx77tjhTODZeL9yY%2B6SZKSS3SehzOalmWEBj2EIV9ipEiKLJrbOB6PcWtMq8QawgmevGRXHz9Xzw4tIJKszPM5oipxdYO4Nyk4J7zbPLsNDN54C%2Bxr3El9h5fluMS39tkBfNyE2sP0N%2BoGwaPkrfCj0sxhStKUjuq%2FRJPicdc2BGUn1sIlmORxiUnwlVGOCYM8w5yS6sqd%2BScJpQtjFeVfkO9jlwj0YUJv1KmRSrmJkeVNzQrMWU0TXDeiqVj6yphtKiHlzcA0oQv37RH0tLG4SCsBtCFFkaakqMN3b0JCc1rmj4%2FZgdSvGJoArYhgKS%2BCCMMUQ7Fwb6qkDBd%2BZP8Z43eA%2BTllly%2BXyyVCzOhGtjvhvdTt9LQow2B614Re73coVP0AMwGrpsYFAAA%3D&strategy=desktop&category=performance&category=accessibility&category=best-practices&category=seo&utm_source=lh-chrome-ext

image

@coliff coliff mentioned this issue Jul 1, 2021
Closed
@adamraine adamraine mentioned this issue Dec 2, 2021
Merged
@HijadelUFO HijadelUFO mentioned this issue May 13, 2024
Open
@kalpatarurudra kalpatarurudra mentioned this issue May 13, 2024
Open
@ashubagri ashubagri mentioned this issue May 13, 2024
Open
@ryan-ally ryan-ally mentioned this issue May 13, 2024
Open
@thexdesk thexdesk mentioned this issue May 14, 2024
Open
@cr-icon cr-icon mentioned this issue May 14, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulirish paulirish

Labels
bug needs-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc(treemap): add lang to html tag GoogleChrome/lighthouse
misc(treemap): add locale to html tag
3 participants
@paulirish @coliff @devtools-bot