Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes scoring #509

Merged
merged 2 commits into from
Jul 18, 2016
Merged

Fixes scoring #509

merged 2 commits into from
Jul 18, 2016

Conversation

paullewis
Copy link
Contributor

A few per tests were using toFixed values (string) where the expected values were numbers. The aggregator was silently discarding them.

I have:

  1. Fixed audits so they output the correct type
  2. Changed the aggregator to throw on incorrect types so that we don't regress

@paullewis
Copy link
Contributor Author

Paging @samccone ... I don't get why the smoke test is failing. It says the offline test failed, but the output implies otherwise.

https://travis-ci.org/GoogleChrome/lighthouse/jobs/144695894#L2542-L2551

@paulirish
Copy link
Member

I think this test is just flaky. Restarting that travis build.

@paullewis paullewis mentioned this pull request Jul 14, 2016
Closed
@paulirish
Copy link
Member

Thanks. I was hitting this and it was a bear to debug.

@paulirish paulirish merged commit bcff128 into master Jul 18, 2016
@paulirish paulirish added the +1 label Jul 18, 2016
@paulirish paulirish deleted the scorefix branch July 26, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullewis @paulirish